CUB-45: Final AgentCard component integration

- Replaced inline status dot/label with AgentStatusBadgeComponent (CUB-48)
- Replaced inline mat-progress-bar with TaskProgressBarComponent (CUB-44)
- Replaced inline jump button with QuickJumpButtonComponent (CUB-46)
- Left-border accent remains, driven by --agent-status-color CSS variable
- All 6 inputs working: status, task, progress, sessionKey, channel, lastActivity
- Added jumpClick output that forwards QuickJumpButton events
- role=article and aria-label on card element
- Fixed QuickJumpButton sessionKey to be @Input() for proper Angular binding
- Added barrel export for quick-jump-button
- Updated components barrel export for all sub-components
- Build and type-check pass cleanly
This commit is contained in:
cubecraft-agents[bot]
2026-04-26 13:52:00 +00:00
parent 63f5790d39
commit fc12ab31a4
7 changed files with 95 additions and 143 deletions

View File

@@ -1,6 +1,7 @@
<article <article
class="agent-card" class="agent-card"
[class]="'agent-card--' + status()" [class]="'agent-card--' + status()"
role="article"
[attr.aria-label]="'Agent card: ' + statusLabel() + ' status'" [attr.aria-label]="'Agent card: ' + statusLabel() + ' status'"
[style.--agent-status-color]="statusColorVar()" [style.--agent-status-color]="statusColorVar()"
[style.--agent-status-bg]="statusBgVar()" [style.--agent-status-bg]="statusBgVar()"
@@ -10,18 +11,14 @@
<!-- Card body --> <!-- Card body -->
<div class="agent-card__body"> <div class="agent-card__body">
<!-- Header row: status dot + status label + channel + last activity --> <!-- Header row: status badge + channel + last activity -->
<div class="agent-card__header"> <div class="agent-card__header">
<div class="agent-card__status-row"> <div class="agent-card__status-row">
<span <!-- Agent Status Badge (CUB-48) -->
class="status-dot agent-card__dot" <app-agent-status-badge
[ngClass]="[statusDotClass()]" [status]="status()"
[attr.aria-label]="statusLabel() + ' status indicator'" [showLabel]="true"
role="status" ></app-agent-status-badge>
></span>
<span class="agent-card__status-label" [style.color]="statusColorVar()">
{{ statusLabel() }}
</span>
</div> </div>
<div class="agent-card__meta"> <div class="agent-card__meta">
@if (channel()) { @if (channel()) {
@@ -39,33 +36,23 @@
<p class="agent-card__task">{{ task() }}</p> <p class="agent-card__task">{{ task() }}</p>
} }
<!-- Progress bar --> <!-- Task Progress Bar (CUB-44) -->
@if (showProgress()) { @if (showProgress()) {
<div class="agent-card__progress"> <app-task-progress-bar
<mat-progress-bar [progress]="progress()"
mode="determinate" [showElapsed]="false"
[value]="progress()" ></app-task-progress-bar>
[attr.aria-label]="'Task progress: ' + progress() + '%'"
></mat-progress-bar>
<div class="agent-card__progress-info">
<span class="text-mono">{{ progress() }}%</span>
</div>
</div>
} }
<!-- Footer: session key (truncated) + jump button --> <!-- Footer: session key (truncated) + Quick-Jump Button (CUB-46) -->
<div class="agent-card__footer"> <div class="agent-card__footer">
<span class="agent-card__session text-mono" [matTooltip]="sessionKey()"> <span class="agent-card__session text-mono" [matTooltip]="sessionKey()">
{{ sessionKey().length > 28 ? sessionKey().substring(0, 28) + '…' : sessionKey() }} {{ sessionKey().length > 28 ? sessionKey().substring(0, 28) + '…' : sessionKey() }}
</span> </span>
<button <app-quick-jump-button
mat-icon-button [sessionKey]="sessionKey()"
class="agent-card__jump" (jumpClick)="jumpClick.emit($event)"
[attr.aria-label]="'Jump to agent session'" ></app-quick-jump-button>
matTooltip="Jump to session"
>
<mat-icon>arrow_forward</mat-icon>
</button>
</div> </div>
</div> </div>
</article> </article>

View File

@@ -1,7 +1,9 @@
// ============================================================================ // ============================================================================
// Agent Card Styles — M3 Tactical Dark // Agent Card Styles — M3 Tactical Dark (Final Integration, CUB-45)
// Per spec Section 7.3: Agent Card Component // Uses sub-components:
// Section 7.5: Animation Specs // - AgentStatusBadge (CUB-48) for status display
// - TaskProgressBar (CUB-44) for progress
// - QuickJumpButton (CUB-46) for navigation
// ============================================================================ // ============================================================================
// --------------------------------------------------------------------------- // ---------------------------------------------------------------------------
@@ -78,17 +80,6 @@
gap: 8px; gap: 8px;
} }
.agent-card__dot {
flex-shrink: 0;
}
.agent-card__status-label {
font-size: 14px;
font-weight: 600;
text-transform: uppercase;
letter-spacing: 0.05em;
}
.agent-card__meta { .agent-card__meta {
display: flex; display: flex;
align-items: center; align-items: center;
@@ -129,23 +120,11 @@
} }
// --------------------------------------------------------------------------- // ---------------------------------------------------------------------------
// Progress Bar // Task Progress Bar (CUB-44 sub-component)
// Override the sub-component's progress bar colors to match status color
// --------------------------------------------------------------------------- // ---------------------------------------------------------------------------
.agent-card__progress { :host ::ng-deep .task-progress-bar .mat-mdc-progress-bar,
display: flex; .agent-card .mat-mdc-progress-bar {
flex-direction: column;
gap: 4px;
}
.agent-card__progress-info {
display: flex;
justify-content: flex-end;
font-size: 12px;
color: var(--cc-on-surface-variant);
}
// Override M3 progress bar track to use status color
.agent-card__progress .mat-mdc-progress-bar {
--mdc-linear-progress-active-indicator-color: var(--agent-status-color); --mdc-linear-progress-active-indicator-color: var(--agent-status-color);
--mdc-linear-progress-track-color: var(--agent-status-bg); --mdc-linear-progress-track-color: var(--agent-status-bg);
} }
@@ -172,53 +151,6 @@
min-width: 0; min-width: 0;
} }
// ---------------------------------------------------------------------------
// Quick-Jump Button — M3 FilledTonalIconButton style
// Per spec: → Jump button using M3 FilledTonalIconButton
// ---------------------------------------------------------------------------
.agent-card__jump {
// M3 FilledTonal style: secondary container color
--mdc-icon-button-icon-color: var(--cc-on-surface);
background-color: var(--cc-surface-container-high);
border-radius: 50%;
width: 40px;
height: 40px;
flex-shrink: 0;
// State layer overlay on hover (8% primary)
&::before {
content: '';
position: absolute;
inset: 0;
border-radius: 50%;
background-color: rgba(255, 255, 255, 0.08);
opacity: 0;
transition: opacity 150ms ease;
pointer-events: none;
}
&:hover::before {
opacity: 1;
}
// Focus-visible ring
&:focus-visible {
outline: 3px solid var(--status-active);
outline-offset: 2px;
}
// Active state
&:active {
transform: scale(0.95);
}
.mat-icon {
font-size: 20px;
width: 20px;
height: 20px;
}
}
// --------------------------------------------------------------------------- // ---------------------------------------------------------------------------
// Status-specific card backgrounds (subtle tint) // Status-specific card backgrounds (subtle tint)
// --------------------------------------------------------------------------- // ---------------------------------------------------------------------------
@@ -236,15 +168,6 @@
// Idle and offline use default surface-container // Idle and offline use default surface-container
// ---------------------------------------------------------------------------
// Touch-First Targets
// ---------------------------------------------------------------------------
// Minimum touch target: 48px (M3 standard)
.agent-card__jump {
min-width: 48px;
min-height: 48px;
}
// --------------------------------------------------------------------------- // ---------------------------------------------------------------------------
// Accessibility: Reduced Motion // Accessibility: Reduced Motion
// --------------------------------------------------------------------------- // ---------------------------------------------------------------------------
@@ -252,14 +175,6 @@
.agent-card { .agent-card {
transition: none; transition: none;
} }
.agent-card__jump {
transition: none;
&:active {
transform: none;
}
}
} }
// --------------------------------------------------------------------------- // ---------------------------------------------------------------------------

View File

@@ -1,19 +1,31 @@
// ============================================================================ // ============================================================================
// Agent Card Component // Agent Card Component — Final Integration
// Per spec Section 7.3: Agent Card Component Interface // Per CUB-45: Compose AgentCard from all sub-components.
// Section 7.5: Animation Specs // - AgentStatusBadge (CUB-48) for status display
// - TaskProgressBar (CUB-44) for progress indication
// - QuickJumpButton (CUB-46) for session navigation
// Layout: left-border accent, aria-labels, role="article"
// ============================================================================ // ============================================================================
import { ChangeDetectionStrategy, Component, input, computed } from '@angular/core'; import { ChangeDetectionStrategy, Component, EventEmitter, Output, input, computed } from '@angular/core';
import { CommonModule } from '@angular/common'; import { CommonModule } from '@angular/common';
import { MatIconModule } from '@angular/material/icon'; import { MatIconModule } from '@angular/material/icon';
import { MatButtonModule } from '@angular/material/button';
import { MatProgressBarModule } from '@angular/material/progress-bar';
import { MatTooltipModule } from '@angular/material/tooltip'; import { MatTooltipModule } from '@angular/material/tooltip';
import { AgentStatus } from '../../models/agent.model';
// Sub-components (CUB-48, CUB-44, CUB-46)
import { AgentStatusBadgeComponent } from '../agent-status-badge';
import { TaskProgressBarComponent } from '../task-progress-bar';
import { QuickJumpButtonComponent } from '../quick-jump-button';
import { AgentStatus } from '../../models';
/** /**
* AgentCard displays a single agent's status in the Command Hub grid. * AgentCard displays a single agent's status in the Command Hub grid.
* *
* Composes three sub-components:
* - AgentStatusBadge: colored pill with pulse animation (CUB-48)
* - TaskProgressBar: determinate progress with optional elapsed time (CUB-44)
* - QuickJumpButton: M3 FilledTonal icon button for session navigation (CUB-46)
*
* Inputs: * Inputs:
* - status: AgentStatus — current agent status * - status: AgentStatus — current agent status
* - task: string — current task description * - task: string — current task description
@@ -22,9 +34,14 @@ import { AgentStatus } from '../../models/agent.model';
* - channel: string — communication channel (e.g., "telegram") * - channel: string — communication channel (e.g., "telegram")
* - lastActivity: Date — timestamp of last activity * - lastActivity: Date — timestamp of last activity
* *
* Outputs:
* - jumpClick: string — emitted when Quick-Jump button is clicked, carries sessionKey
*
* Accessibility: * Accessibility:
* - role="article" on the card element * - role="article" on the card element
* - aria-labels for status badge and interactive elements * - aria-label on the card summarizing status
* - aria-label on the progress bar (via TaskProgressBar)
* - aria-label on the Quick-Jump button (via QuickJumpButton)
* - focus-visible outlines for keyboard navigation * - focus-visible outlines for keyboard navigation
*/ */
@Component({ @Component({
@@ -33,15 +50,21 @@ import { AgentStatus } from '../../models/agent.model';
imports: [ imports: [
CommonModule, CommonModule,
MatIconModule, MatIconModule,
MatButtonModule,
MatProgressBarModule,
MatTooltipModule, MatTooltipModule,
// Sub-components
AgentStatusBadgeComponent,
TaskProgressBarComponent,
QuickJumpButtonComponent,
], ],
templateUrl: './agent-card.component.html', templateUrl: './agent-card.component.html',
styleUrl: './agent-card.component.scss', styleUrl: './agent-card.component.scss',
changeDetection: ChangeDetectionStrategy.OnPush, changeDetection: ChangeDetectionStrategy.OnPush,
}) })
export class AgentCardComponent { export class AgentCardComponent {
// ---------------------------------------------------------------------------
// Inputs (all 6 required by CUB-45 definition of done)
// ---------------------------------------------------------------------------
/** Current agent status */ /** Current agent status */
readonly status = input.required<AgentStatus>(); readonly status = input.required<AgentStatus>();
@@ -60,6 +83,17 @@ export class AgentCardComponent {
/** Timestamp of last activity */ /** Timestamp of last activity */
readonly lastActivity = input<Date>(new Date()); readonly lastActivity = input<Date>(new Date());
// ---------------------------------------------------------------------------
// Outputs
// ---------------------------------------------------------------------------
/** Emitted when the Quick-Jump button is clicked with the session key. */
@Output() readonly jumpClick = new EventEmitter<string>();
// ---------------------------------------------------------------------------
// Computed values
// ---------------------------------------------------------------------------
/** Map status to CSS custom property name for dynamic color binding */ /** Map status to CSS custom property name for dynamic color binding */
readonly statusColorVar = computed(() => { readonly statusColorVar = computed(() => {
const map: Record<AgentStatus, string> = { const map: Record<AgentStatus, string> = {
@@ -84,7 +118,7 @@ export class AgentCardComponent {
return map[this.status()]; return map[this.status()];
}); });
/** Human-readable status label */ /** Human-readable status label (delegates to AgentStatusBadgeComponent) */
readonly statusLabel = computed(() => { readonly statusLabel = computed(() => {
const map: Record<AgentStatus, string> = { const map: Record<AgentStatus, string> = {
active: 'Active', active: 'Active',
@@ -96,9 +130,6 @@ export class AgentCardComponent {
return map[this.status()]; return map[this.status()];
}); });
/** CSS class for status dot animation */
readonly statusDotClass = computed(() => `status-dot--${this.status()}`);
/** Format last activity as relative time string */ /** Format last activity as relative time string */
readonly lastActivityText = computed(() => { readonly lastActivityText = computed(() => {
const now = Date.now(); const now = Date.now();

View File

@@ -1 +1,6 @@
// ============================================================================
// Agent Card — Barrel Export
// CUB-45: Final integration with sub-components
// ============================================================================
export { AgentCardComponent } from './agent-card.component'; export { AgentCardComponent } from './agent-card.component';

View File

@@ -1 +1,8 @@
export * from './quick-jump-button/quick-jump-button.component'; // ============================================================================
// Components Barrel Export
// ============================================================================
export * from './agent-card';
export * from './agent-status-badge';
export * from './task-progress-bar';
export * from './quick-jump-button';

View File

@@ -0,0 +1,6 @@
// ============================================================================
// Quick-Jump Button — Barrel Export
// CUB-46
// ============================================================================
export { QuickJumpButtonComponent } from './quick-jump-button.component';

View File

@@ -1,4 +1,4 @@
import { ChangeDetectionStrategy, Component, EventEmitter, Output } from '@angular/core'; import { ChangeDetectionStrategy, Component, EventEmitter, Input, Output } from '@angular/core';
import { MatIconButton } from '@angular/material/button'; import { MatIconButton } from '@angular/material/button';
import { MatIcon } from '@angular/material/icon'; import { MatIcon } from '@angular/material/icon';
@@ -20,12 +20,13 @@ import { MatIcon } from '@angular/material/icon';
changeDetection: ChangeDetectionStrategy.OnPush, changeDetection: ChangeDetectionStrategy.OnPush,
}) })
export class QuickJumpButtonComponent { export class QuickJumpButtonComponent {
/** The session key to navigate to. Set by the parent agent card. */
@Input()
sessionKey = '';
/** Emitted when the button is clicked, carrying the session key for navigation. */ /** Emitted when the button is clicked, carrying the session key for navigation. */
@Output() jumpClick = new EventEmitter<string>(); @Output() jumpClick = new EventEmitter<string>();
/** The session key to navigate to. Set by the parent agent card. */
sessionKey = '';
onJumpClick(): void { onJumpClick(): void {
this.jumpClick.emit(this.sessionKey); this.jumpClick.emit(this.sessionKey);
} }