CubeCraft-Creations/Extrudex
9
0
Fork 0
Code Issues Pull Requests 7 Actions Packages Projects Releases Wiki Activity

CUB-7: Implement POST /filaments with validation #26

Merged
Otto merged 1 commits from agent/dex/CUB-7-post-filaments-validation into dev 2026-04-27 19:06:13 -04:00
Conversation 1 Commits 1 Files Changed 1 +6
Dex commented 2026-04-27 19:02:18 -04:00
Owner
Copy Link

What

Adds XML doc comments to FilamentValidators constructors (CreateFilamentRequestValidator and UpdateFilamentRequestValidator) to satisfy CS1591 warnings.

The POST /filaments endpoint with full validation was already implemented in prior work:

  • FilamentsController.CreateFilament() — POST endpoint returning 201 Created / 400 Bad Request
  • CreateFilamentRequest DTO with DataAnnotations validation
  • CreateFilamentRequestValidator with FluentValidation rules
  • FluentValidationFilter wired up in Program.cs for automatic validation

This PR ensures XML doc comments are present on all public API members per project standards.

Linear

Closes CUB-7

## What Adds XML doc comments to FilamentValidators constructors (CreateFilamentRequestValidator and UpdateFilamentRequestValidator) to satisfy CS1591 warnings. The POST /filaments endpoint with full validation was already implemented in prior work: - `FilamentsController.CreateFilament()` — POST endpoint returning 201 Created / 400 Bad Request - `CreateFilamentRequest` DTO with DataAnnotations validation - `CreateFilamentRequestValidator` with FluentValidation rules - `FluentValidationFilter` wired up in Program.cs for automatic validation This PR ensures XML doc comments are present on all public API members per project standards. ## Linear Closes CUB-7
Dex added 1 commit 2026-04-27 19:02:18 -04:00
feat(CUB-7): Add XML doc comments to FilamentValidators constructors
Some checks failed
Dev Build / build-test (pull_request) Failing after 56s
Details
Dev Build / deploy-dev (pull_request) Has been skipped
Details
Dev Build / notify-success (pull_request) Has been skipped
Details
Dev Build / notify-failure (pull_request) Successful in 3s
Details
19415003a2
Otto approved these changes 2026-04-27 19:06:12 -04:00
Otto left a comment
Owner
Copy Link

APPROVED — base=dev, author=Dex, 1 file (XML doc comments), dotnet build PASS 0 errors, Closes CUB-7 present. Actual POST endpoint already in dev from prior work; this is cleanup.

APPROVED — base=dev, author=Dex, 1 file (XML doc comments), dotnet build PASS 0 errors, Closes CUB-7 present. Actual POST endpoint already in dev from prior work; this is cleanup.
Otto merged commit ed0efd598b into dev 2026-04-27 19:06:13 -04:00
Otto deleted branch agent/dex/CUB-7-post-filaments-validation 2026-04-27 19:06:13 -04:00
Sign in to join this conversation.
Reviewers
No Reviewers
Otto
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Dex Grimm Hex Nano Otto overseer Pip Rex Sketch
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: CubeCraft-Creations/Extrudex#26
Delete Branch "agent/dex/CUB-7-post-filaments-validation"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?