Files
remote-rig/internal/api/recording.go
T
Hermes 1f253283f8
CI/CD / lint-and-typecheck (pull_request) Failing after 12m11s
CI/CD / test (pull_request) Has been cancelled
CI/CD / build (pull_request) Has been cancelled
CI/CD / deploy (pull_request) Has been cancelled
fix: harden camera API endpoints (CUB-234)
- Add request validation: Content-Type check, body size limit (64KB)
- Add field length validation (camera_id: 64, friendly_name: 128, mode: 32, resolution: 32)
- Add FPS range validation (0-240)
- Add battery_pct range validation (0-100)
- Replace ad-hoc map[string]string errors with structured APIError {error, code, details}
- Fix isUniqueConstraintErr to catch both camera_id and mac_address constraint violations
- Fix MacAddress model field from string to *string for NULL handling
- Fix splitSQL to strip -- line comments before splitting (was causing migration failures with modernc.org/sqlite)
- Add 30 integration tests covering all endpoints
- All tests pass: ok github.com/cubecraft/remoterig/internal/api
2026-05-23 08:50:21 -04:00

97 lines
2.8 KiB
Go

// Package api provides HTTP handlers for camera operations.
package api
import (
"log"
"net/http"
"github.com/cubecraft/remoterig/internal/db"
"github.com/go-chi/chi/v5"
)
// StartRecording returns a handler for POST /cameras/{id}/start.
func StartRecording(database *db.DB) http.HandlerFunc {
return func(w http.ResponseWriter, r *http.Request) {
cameraID := chi.URLParam(r, "id")
if !validateCameraID(w, cameraID) {
return
}
// Check if camera is registered
var exists int
err := database.QueryRowContext(r.Context(),
"SELECT COUNT(*) FROM cameras WHERE camera_id = ?", cameraID).Scan(&exists)
if err != nil {
log.Printf("Error checking camera existence: %v", err)
respondError(w, http.StatusInternalServerError, "database error", err.Error())
return
}
if exists == 0 {
respondError(w, http.StatusNotFound, "camera not found")
return
}
// Open recording event
result, err := database.ExecContext(r.Context(), `
INSERT INTO recording_events (camera_id, started_at, reason)
VALUES (?, datetime('now'), 'manual')
`, cameraID)
if err != nil {
log.Printf("Error starting recording: %v", err)
respondError(w, http.StatusInternalServerError, "database error", err.Error())
return
}
rowsAffected, _ := result.RowsAffected()
log.Printf("Recording started on %s (%d rows affected)", cameraID, rowsAffected)
respondJSON(w, http.StatusOK, map[string]string{
"status": "recording_started",
"camera_id": cameraID,
})
}
}
// StopRecording returns a handler for POST /cameras/{id}/stop.
func StopRecording(database *db.DB) http.HandlerFunc {
return func(w http.ResponseWriter, r *http.Request) {
cameraID := chi.URLParam(r, "id")
if !validateCameraID(w, cameraID) {
return
}
// Check if camera is registered
var exists int
err := database.QueryRowContext(r.Context(),
"SELECT COUNT(*) FROM cameras WHERE camera_id = ?", cameraID).Scan(&exists)
if err != nil {
log.Printf("Error checking camera existence: %v", err)
respondError(w, http.StatusInternalServerError, "database error", err.Error())
return
}
if exists == 0 {
respondError(w, http.StatusNotFound, "camera not found")
return
}
// Close the most recent open recording event
result, err := database.ExecContext(r.Context(), `
UPDATE recording_events SET stopped_at = datetime('now'), reason = 'manual'
WHERE camera_id = ? AND stopped_at IS NULL
`, cameraID)
if err != nil {
log.Printf("Error stopping recording: %v", err)
respondError(w, http.StatusInternalServerError, "database error", err.Error())
return
}
rowsAffected, _ := result.RowsAffected()
log.Printf("Recording stopped on %s (%d rows affected)", cameraID, rowsAffected)
respondJSON(w, http.StatusOK, map[string]string{
"status": "recording_stopped",
"camera_id": cameraID,
})
}
}